Path Manipulation - Revision history

ChrFranke: /* Warning */ Add link to safe version of AddToPath, remove smartmontools link

2022-12-13T14:40:09Z

Warning: Add link to safe version of AddToPath, remove smartmontools link

â† Older revision		Revision as of 14:40, 13 December 2022
Line 27:		Line 27:

	This could be fixed by using the native Win32 function [https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911.aspx RegQueryValueEx()] instead.		This could be fixed by using the native Win32 function [https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911.aspx RegQueryValueEx()] instead.
	See [~~http://www.smartmontools.org/browser/trunk/smartmontools/os_win32/installer.nsi?rev=4110#L636~~ this ~~installer~~] for a working example.		See [[AddToPath safe\|this alternative implementation]] for a working example.

	=== Syntax ===		=== Syntax ===

Anders: EnVar_plug-in hint

2020-03-10T22:22:21Z

EnVar_plug-in hint

â† Older revision		Revision as of 22:22, 10 March 2020
Line 1:		Line 1:
	{{PageAuthor\|turnec2}}		{{PageAuthor\|turnec2}}

	<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%.</font> (See [[#Warning\|below]] for a link to an alternative implementation.)</div>		<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%, use the [[EnVar_plug-in]] instead.</font> (See [[#Warning\|below]] for a link to an alternative implementation.)</div>

Bugmenot: /* Usage */ interwikis formatting

2016-01-07T17:23:14Z

Usage: interwikis formatting

â† Older revision		Revision as of 17:23, 7 January 2016
Line 16:		Line 16:
	== Usage ==		== Usage ==

	See [[~~Environmental_Variables~~:~~_append~~,~~_prepend~~,~~_and_remove_entries~~]] for more details.		See [[Environmental Variables: append, prepend, and remove entries]] for more details.

	=== Warning ===		=== Warning ===
Line 22:		Line 22:
	'''Warning : this code will replace paths rather than append if the existing path exceeds the maximum string length in the NSIS build you are using. Some setup crash can also occurs.'''		'''Warning : this code will replace paths rather than append if the existing path exceeds the maximum string length in the NSIS build you are using. Some setup crash can also occurs.'''

	Default maximum string length is 1024, see [[~~Special_Builds~~]] for a 8192 max length.		Default maximum string length is 1024, see [[Special Builds]] for a 8192 max length.

	The problem occurs because the function [[Reference/ReadRegStr\|ReadRegStr]] returns the same result if 'value is too long' and if 'value is not set'.		The problem occurs because the function [[Reference/ReadRegStr\|ReadRegStr]] returns the same result if 'value is too long' and if 'value is not set'.

Bugmenot: /* Function Code */ interwiki link

2016-01-07T17:21:42Z

Function Code: interwiki link

â† Older revision		Revision as of 17:21, 7 January 2016
Line 91:		Line 91:
	== Function Code ==		== Function Code ==

	[[~~http~~:~~//nsis.sourceforge.net/Environmental_Variables:_append%2C_prepend%2C_and_remove_entries~~#~~Function_Code~~ EnvVarUpdate function code]]		[[Environmental Variables: append, prepend, and remove entries#Function Code\|EnvVarUpdate function code]]


	== Functions for Windows 95, 98, and ME ==		== Functions for Windows 95, 98, and ME ==

ChrFranke: /* Warning */ Fix info about ReadRegStr overflow handling

2015-06-15T17:34:36Z

Warning: Fix info about ReadRegStr overflow handling

â† Older revision		Revision as of 17:34, 15 June 2015
Line 24:		Line 24:
	Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.		Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.

	The problem occurs because the function [[Reference/ReadRegStr\|ReadRegStr]] ~~'''silently'''~~ returns ~~an empty string~~ if ~~the length of the registry~~ value ~~exceeds ${NSIS_MAX_STRLEN}.~~		The problem occurs because the function [[Reference/ReadRegStr\|ReadRegStr]] returns the same result if 'value is too long' and if 'value is not set'.
	~~ReadRegStr does '~~''not'~~'' set the error flag in this case~~.

	This could be fixed by using the native Win32 function [https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911.aspx RegQueryValueEx()] instead.		This could be fixed by using the native Win32 function [https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911.aspx RegQueryValueEx()] instead.
	See [http://www.smartmontools.org/browser/trunk/smartmontools/os_win32/installer.nsi?rev=4110#L636 this installer] for a working example.		See [http://www.smartmontools.org/browser/trunk/smartmontools/os_win32/installer.nsi?rev=4110#L636 this installer] for a working example.


	=== Syntax ===		=== Syntax ===

ChrFranke: + Link to sample without NSIS_MAX_STRLEN corruption

2015-06-11T11:09:32Z

+ Link to sample without NSIS_MAX_STRLEN corruption

â† Older revision		Revision as of 11:09, 11 June 2015
Line 1:		Line 1:
	{{PageAuthor\|turnec2}}		{{PageAuthor\|turnec2}}

	<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%</font></div>		<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%.</font> (See [[#Warning\|below]] for a link to an alternative implementation.)</div>


Line 23:		Line 23:

	Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.		Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.

			The problem occurs because the function [[Reference/ReadRegStr\|ReadRegStr]] '''silently''' returns an empty string if the length of the registry value exceeds ${NSIS_MAX_STRLEN}.
			ReadRegStr does '''not''' set the error flag in this case.

			This could be fixed by using the native Win32 function [https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911.aspx RegQueryValueEx()] instead.
			See [http://www.smartmontools.org/browser/trunk/smartmontools/os_win32/installer.nsi?rev=4110#L636 this installer] for a working example.

Anders at 19:15, 23 February 2014

2014-02-23T19:15:38Z

â† Older revision		Revision as of 19:15, 23 February 2014
Line 2:		Line 2:

	<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%</font></div>		<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%</font></div>


	== Description ==		== Description ==

Anders: Added NSIS_MAX_STRLEN corruption warning

2014-02-23T19:14:46Z

Added NSIS_MAX_STRLEN corruption warning

â† Older revision		Revision as of 19:14, 23 February 2014
Line 1:		Line 1:
	{{PageAuthor\|turnec2}}		{{PageAuthor\|turnec2}}

			<div style="background-color:#ff9999; color:#f00; border:2px solid #f00; padding:1em;"><font size="+1"><b>WARNING:</b> Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%</font></div>

	== Description ==		== Description ==

129.130.40.208: /* Warning */

2011-06-29T23:40:44Z

Warning

â† Older revision		Revision as of 23:40, 29 June 2011
Line 22:		Line 22:
	Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.		Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.

	~~The following patch is suggested to foolproof this problem. It has a remaining problem in that if~~
	~~the path is initially empty it will not allow adding to it. This could be fixed by adding a test~~
	~~to only use this patch when $1 is PATH, but then long non-path environments could be trashed.~~
	~~[[Special:Contributions/129.130.40.208\|129.130.40.208]] 23:25, 29 June 2011 (UTC)~~
	~~<highlight-nsis>~~

	~~> diff -c EnvVarUpdate.nsh /usr/share/nsis/Include/EnvVarUpdate-safe.nsh~~
	*** EnvVarUpdate.nsh 2011-06-28 16:45:20.000000000 -0500
	~~--- /usr/share/nsis/Include/EnvVarUpdate-safe.nsh 2011-06-29 15:28:41.000000000 -0500~~
	~~***************~~
	~~* 147,152 **~~
	~~--- 147,172 ----~~
	~~;;khc - here check if length is going to be greater then max string length~~
	~~;; and abort if so - also abort if original path empty - may mean~~
	~~;; it was too long as well- write message to say set it by hand~~
	+
	~~+ Push $6~~
	~~+ Push $7~~
	~~+ Push $8~~
	~~+ StrLen $7 $4~~
	~~+ StrLen $6 $5~~
	~~+ IntOp $8 $6 + $7~~
	~~+ ${If} $5 == ""~~
	~~+ ${OrIf} $8 >= ${NSIS_MAX_STRLEN}~~
	~~+ SetErrors~~
	~~+ DetailPrint "Current $1 length ($6) too long to modify in NSIS; set manually if needed"~~
	~~+ Pop $8~~
	~~+ Pop $7~~
	~~+ Pop $6~~
	~~+ Goto EnvVarUpdate_Restore_Vars~~
	~~+ ${EndIf}~~
	~~+ Pop $8~~
	~~+ Pop $7~~
	~~+ Pop $6~~
	~~+ ;;khc~~
	~~; Make sure we've got some work to do~~
	~~${If} $5 == ""~~
	~~${AndIf} $2 == "R"~~

	=== Syntax ===		=== Syntax ===

129.130.40.208: /* Warning */

2011-06-29T23:25:27Z

Warning

@@ Line 20: / Line 20: @@
 '''Warning : this code will replace paths rather than append if the existing path exceeds the maximum string length in the NSIS build you are using. Some setup crash can also occurs.'''
 Default maximum string length is 1024, see [[Special_Builds]] for a 8192 max length.
 === Syntax ===