Talk:Auto-uninstall old before installing new - Revision history

Anders: Reverted edits by 94.23.238.222 to last version by Anders

2013-05-15T20:25:41Z

Reverted edits by 94.23.238.222 to last version by Anders

â† Older revision		Revision as of 20:25, 15 May 2013
Line 1:		Line 1:
	~~Wow! Great~~ to ~~find~~ a ~~post knokicng~~ my ~~socks off!~~		== Jeff's comments ==
			In the second example, doesn't that assume that the old version's uninstaller is called 'uninst.exe' and that it resides in the same directory we're trying to install the new version into? The first example is using the value stored in the uninstall string key in the registry, which is a more robust way of doing it.

			Also, in the first example, shouldn't you have a second parameter to iferrors?
			<code>
			IfErrors uninstall_failed uninstall_succeeded
			uninstall_failed:
			;You can either use Delete /REBOOTOK in the uninstaller or add some code
			;here to remove the uninstaller. Use a registry key to check
			;whether the user has chosen to uninstall. If you are using an uninstaller
			;components page, make sure all sections are uninstalled.
			uninstall_succeeded:
			;now you won't do the above deletion or whatever if the uninstall succeeded.
			</code>

			== Hans's comments ==

			Consider the following Scenario:

			<code>

			(1) the installer GUI pops up
			(2) the user changes some settings
			(3) but finally the user decides to abort the installation

			</code>

			Since the installation has been canceled by the user the old installation should still be present.

			But if you call the uninstaller in the onInit callback then the old installation is gone.

			maybe it's possible to perform such on uninstallation in the onGUIEnd callback?

			but for silent installation the onGUIEnd callback is not called at all.

			Possible solution:

			<code>

			have one central function to perform the uninstallation (e.g. doMyUnInstall) and then ...
			in the onGUIEnd callback use doMyUnInstall
			in the onInit callback check with the IsSilent function. If Yes then call doMyUnInstall

			</code>

			== Jeff Baylor's comments ==

			I have been using this code snippet and really appreciate your posting it. Recently I realized that it fails if the $INSTDIR is not the same as previous install directory. I have modified it to be:

			<highlight-nsis>
			...
			uninst:
			ReadRegStr $R1 HKLM \
			"Software\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \
			"InstallLocation"

			ClearErrors
			ExecWait '$R0 _?=$R1' ; Do not copy the uninstaller to $TEMP or $INSTDIR
			...
			</highlight-nsis>

			== Sacha's comments ==

			In my case I only needed to uninstall the previous version is case the user is installing it in the same folder as the previous one.

			Hence I chose to silently uninstall with this line:
			<highlight-nsis>
			ExecWait '"$INSTDIR\uninst.exe" /S _?=$INSTDIR'
			</highlight-nsis>

			== Tossnet's comments ==

			In my case, on a Windows 7 64bits
			this code must be change

			<highlight-nsis>
			ReadRegStr $R0 HKLM \
			"Software\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \
			"UninstallString"
			</highlight-nsis>

			by this :

			<highlight-nsis>

			HKLM \SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \
			"UninstallString"
			</highlight-nsis>

			So i use another link from the regedit to look after a previus version.

94.23.238.222: Undo revision 19278 by Tossnet (talk)

2013-05-15T11:43:20Z

Undo revision 19278 by Tossnet (talk)

â† Older revision		Revision as of 11:43, 15 May 2013
Line 1:		Line 1:
	~~== Jeff's comments ==~~		Wow! Great to find a post knokicng my socks off!
	~~In the second example, doesn't that assume that the old version's uninstaller is called 'uninst.exe' and that it resides in the same directory we're trying~~ to ~~install the new version into? The first example is using the value stored in the uninstall string key in the registry, which is~~ a ~~more robust way of doing it.~~

	~~Also, in the first example, shouldn't you have a second parameter to iferrors?~~
	~~<code>~~
	~~IfErrors uninstall_failed uninstall_succeeded~~
	~~uninstall_failed:~~
	~~;You can either use Delete /REBOOTOK in the uninstaller or add some code~~
	~~;here to remove the uninstaller. Use a registry key to check~~
	~~;whether the user has chosen to uninstall. If you are using an uninstaller~~
	~~;components page, make sure all sections are uninstalled.~~
	~~uninstall_succeeded:~~
	~~;now you won't do the above deletion or whatever if the uninstall succeeded.~~
	~~</code>~~

	~~== Hans's comments ==~~

	~~Consider the following Scenario:~~

	~~<code>~~

	~~(1) the installer GUI pops up~~
	~~(2) the user changes some settings~~
	~~(3) but finally the user decides to abort the installation~~

	~~</code>~~

	~~Since the installation has been canceled by the user the old installation should still be present.~~

	~~But if you call the uninstaller in the onInit callback then the old installation is gone.~~

	~~maybe it's possible to perform such on uninstallation in the onGUIEnd callback?~~

	~~but for silent installation the onGUIEnd callback is not called at all.~~

	~~Possible solution:~~

	~~<code>~~

	~~have one central function to perform the uninstallation (e.g. doMyUnInstall) and then ...~~
	~~in the onGUIEnd callback use doMyUnInstall~~
	~~in the onInit callback check with the IsSilent function. If Yes then call doMyUnInstall~~

	~~</code>~~

	~~== Jeff Baylor's comments ==~~

	I have been using this code snippet and really appreciate your posting it. Recently I realized that it fails if the $INSTDIR is not the same as previous install directory. I have modified it to be:

	~~<highlight-nsis>~~
	~~...~~
	~~uninst:~~
	~~ReadRegStr $R1 HKLM \~~
	~~"Software\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \~~
	~~"InstallLocation"~~

	~~ClearErrors~~
	~~ExecWait '$R0 _?=$R1' ; Do not copy the uninstaller to $TEMP or $INSTDIR~~
	~~...~~
	~~</highlight-nsis>~~

	~~== Sacha's comments ==~~

	~~In my case I only needed to uninstall the previous version is case the user is installing it in the same folder as the previous one.~~

	~~Hence I chose to silently uninstall with this line:~~
	~~<highlight-nsis>~~
	~~ExecWait '"$INSTDIR\uninst.exe" /S _?=$INSTDIR'~~
	~~</highlight-nsis>~~

	~~== Tossnet's comments ==~~

	In my ~~case, on a Windows 7 64bits~~
	~~this code must be change~~

	~~<highlight-nsis>~~
	~~ReadRegStr $R0 HKLM \~~
	~~"Software\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \~~
	~~"UninstallString"~~
	~~</highlight-nsis>~~

	~~by this :~~

	~~<highlight-nsis>~~

	~~HKLM \SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\${PROGRAM_NAME}" \~~
	~~"UninstallString"~~
	~~</highlight-nsis>~~

	~~So i use another link from the regedit to look after a previus version.~~

Anders: Reverted edits by 31.184.238.19 to last version by Anders

2012-01-14T19:14:34Z

Reverted edits by 31.184.238.19 to last version by Anders

â† Older revision		Revision as of 19:14, 14 January 2012
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

	~~== generic viagra bosentan ==~~

	Quite component to written content. I just stumbled upon your websites in addition to accession growth capital to claim that we attain believe it or not experienced bank account your blog post posts. Nonetheless I'll be registering to the passes in addition to My partner and i results people admission dependably rapidly.

31.184.238.19: /* generic viagra bosentan */ new section

2012-01-13T07:34:58Z

generic viagra bosentan: new section

â† Older revision		Revision as of 07:34, 13 January 2012
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

			== generic viagra bosentan ==

			Quite component to written content. I just stumbled upon your websites in addition to accession growth capital to claim that we attain believe it or not experienced bank account your blog post posts. Nonetheless I'll be registering to the passes in addition to My partner and i results people admission dependably rapidly.

Anders: Reverted edits by 31.184.238.19 to last version by Anders

2011-12-02T17:33:47Z

Reverted edits by 31.184.238.19 to last version by Anders

â† Older revision		Revision as of 17:33, 2 December 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

	~~== cheap viagra canada ==~~

	~~Whats up.This amazing page came down to pushing, in particular since i have include was on the search for obtaining gives the field final Thursday.~~

31.184.238.19: /* cheap viagra canada */ new section

2011-12-02T04:47:55Z

cheap viagra canada: new section

â† Older revision		Revision as of 04:47, 2 December 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

			== cheap viagra canada ==

			Whats up.This amazing page came down to pushing, in particular since i have include was on the search for obtaining gives the field final Thursday.

Anders: Reverted edits by 31.184.238.19 to last version by Anders

2011-11-05T18:53:09Z

Reverted edits by 31.184.238.19 to last version by Anders

â† Older revision		Revision as of 18:53, 5 November 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

	~~== generic viagra herbal ==~~

	~~Fascinating post… I’ve definitely happened to be focusing on an individual's blog website up for a time and that i actually much like exactly what you possess attained with it~~

31.184.238.19: /* generic viagra herbal */ new section

2011-11-01T11:16:01Z

generic viagra herbal: new section

â† Older revision		Revision as of 11:16, 1 November 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

			== generic viagra herbal ==

			Fascinating post… I’ve definitely happened to be focusing on an individual's blog website up for a time and that i actually much like exactly what you possess attained with it

Anders: Reverted edits by 31.184.238.19 to last version by Tossnet

2011-10-29T17:11:08Z

Reverted edits by 31.184.238.19 to last version by Tossnet

â† Older revision		Revision as of 17:11, 29 October 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

	~~== viagra generic name joke discount ==~~

	~~Are you experiencing anylonger facts about the?~~

31.184.238.19: /* viagra generic name joke discount */ new section

2011-10-29T16:05:59Z

viagra generic name joke discount: new section

â† Older revision		Revision as of 16:05, 29 October 2011
Line 89:		Line 89:

	So i use another link from the regedit to look after a previus version.		So i use another link from the regedit to look after a previus version.

			== viagra generic name joke discount ==

			Are you experiencing anylonger facts about the?