Talk:FileAssoc - Revision history

Bjudd: /* Missing param in example */

2019-04-10T18:18:29Z

Missing param in example

â† Older revision		Revision as of 18:18, 10 April 2019
Line 50:		Line 50:
	* the "Open with My App" is what shows up in the context menu		* the "Open with My App" is what shows up in the context menu
	[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)		[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)
			<p>
	Hello - I think APP_UNASSOCIATE can be improved. As written, it does not correctly cleanup the .${EXT} key. In my tests on Win2k and XP, the following correctly restores a _backup {		How does one start a new comment?? I am not clever enough to figure it out ... nonetheless ...</p>
			Hello - I think APP_UNASSOCIATE can be improved. As written, it does not correctly cleanup the .${EXT} key. In my tests on Win2k and WinXP, the following correctly restores a _backup {
	${FILECLASS} pointer, or deletes the .${EXT} key entirely if it is no longer in use.		${FILECLASS} pointer, or deletes the .${EXT} key entirely if it is no longer in use.

Bjudd at 18:06, 10 April 2019

2019-04-10T18:06:49Z

â† Older revision		Revision as of 18:06, 10 April 2019
Line 50:		Line 50:
	* the "Open with My App" is what shows up in the context menu		* the "Open with My App" is what shows up in the context menu
	[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)		[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)

			Hello - I think APP_UNASSOCIATE can be improved. As written, it does not correctly cleanup the .${EXT} key. In my tests on Win2k and XP, the following correctly restores a _backup {
			${FILECLASS} pointer, or deletes the .${EXT} key entirely if it is no longer in use.

			!macro APP_UNASSOCIATE EXT FILECLASS
			; Restore the previously associated file class if it differs
			ReadRegStr $R0 HKCR ".${EXT}" `${FILECLASS}_backup`
			DeleteRegValue HKCR ".${EXT}" `${FILECLASS}_backup`
			StrCmp $R0 "" +3 ; No original association
			WriteRegStr HKCR ".${EXT}" "" "$R0"
			Goto +2
			DeleteRegKey HKCR ".${EXT}"
			DeleteRegKey HKCR `${FILECLASS}`

			!macroend

			Also, in both the install macros, the _backup key is overwritten upon re-install of the application, losing the needed value: following are the first lines of APP_ASSOCIATE showing my fix (2 lines w/comments):

			!macro APP_ASSOCIATE EXT FILECLASS DESCRIPTION ICON COMMANDTEXT COMMAND
			; Backup the previously associated file class
			ReadRegStr $R0 HKCR ".${EXT}" ""
			StrCmp $R0 "" +3 ; Nothing to backup
			StrCmp $R0 "${FILECLASS}" +2 ; Don't overwrite original during a re-install
			WriteRegStr HKCR ".${EXT}" "${FILECLASS}_backup" "$R0"

			Thanks for posting the original - it was quite useful. And +2 for very good documentation :-)

127.0.0.1: Remove duplication of section (see previous edit)

2013-02-16T18:09:37Z

Remove duplication of section (see previous edit)

â† Older revision		Revision as of 18:09, 16 February 2013
Line 1:		Line 1:
	~~There is a bug in the script (I think...)~~

	~~In the example you call with five parameters:~~

	~~<nowiki>~~
	~~; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \~~
	~~</nowiki>~~

	~~<nowiki>~~
	~~; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""~~
	~~</nowiki>~~

	~~but in the fuction header there is six patrameters declared:~~


	~~!macro APP_ASSOCIATE EXT FILECLASS DESCRIPTION ICON COMMANDTEXT COMMAND~~


	~~There must be somthing wrong here or?~~

	~~/Pontus~~

	~~: Perhaps a better example would be:~~
	~~<highlight-nsis>~~
	~~!insertmacro APP_ASSOCIATE "myext" "myapp.myext" \~~
	~~"My App File" "$INSTDIR\myapp.exe,0" \~~
	~~"Open with My App" "$INSTDIR\myapp.exe $\"%1$\""~~
	~~</highlight-nsis>~~
	* the "My App File" is what shows up in the Explorer details view
	* the "Open with My App" is what shows up in the context menu
	~~[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)~~

	== quotes fix for COMMAND ==		== quotes fix for COMMAND ==

127.0.0.1: /* Missing param in example */ new section

2013-02-16T18:09:01Z

Missing param in example: new section

â† Older revision		Revision as of 18:09, 16 February 2013
Line 45:		Line 45:

	: Even better, backticks. Done. --[[User:Kichik\|kichik]] 03:45, 31 December 2005 (PST)		: Even better, backticks. Done. --[[User:Kichik\|kichik]] 03:45, 31 December 2005 (PST)

			== Missing param in example ==

			I've just fixed this. Discussion archived below. [[Special:Contributions/127.0.0.1\|127.0.0.1]] 18:09, 16 February 2013 (UTC)


			There is a bug in the script (I think...)

			In the example you call with five parameters:

			<nowiki>
			; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \
			</nowiki>

			<nowiki>
			; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""
			</nowiki>

			but in the fuction header there is six patrameters declared:


			!macro APP_ASSOCIATE EXT FILECLASS DESCRIPTION ICON COMMANDTEXT COMMAND


			There must be somthing wrong here or?

			/Pontus

			: Perhaps a better example would be:
			<highlight-nsis>
			!insertmacro APP_ASSOCIATE "myext" "myapp.myext" \
			"My App File" "$INSTDIR\myapp.exe,0" \
			"Open with My App" "$INSTDIR\myapp.exe $\"%1$\""
			</highlight-nsis>
			* the "My App File" is what shows up in the Explorer details view
			* the "Open with My App" is what shows up in the context menu
			[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)

86.135.85.25: added suggestion to fix problem with first example

2010-10-28T23:04:06Z

added suggestion to fix problem with first example

â† Older revision		Revision as of 23:04, 28 October 2010
Line 20:		Line 20:

	/Pontus		/Pontus

			: Perhaps a better example would be:
			<highlight-nsis>
			!insertmacro APP_ASSOCIATE "myext" "myapp.myext" \
			"My App File" "$INSTDIR\myapp.exe,0" \
			"Open with My App" "$INSTDIR\myapp.exe $\"%1$\""
			</highlight-nsis>
			* the "My App File" is what shows up in the Explorer details view
			* the "Open with My App" is what shows up in the context menu
			[[Special:Contributions/86.135.85.25\|86.135.85.25]] 23:04, 28 October 2010 (UTC)

	== quotes fix for COMMAND ==		== quotes fix for COMMAND ==

Kichik at 11:45, 31 December 2005

2005-12-31T11:45:32Z

â† Older revision		Revision as of 11:45, 31 December 2005
Line 33:		Line 33:

	Cedric.		Cedric.

			: Even better, backticks. Done. --[[User:Kichik\|kichik]] 03:45, 31 December 2005 (PST)

Cedric: quotes fix for COMMAND

2005-12-31T01:02:51Z

quotes fix for COMMAND

â† Older revision		Revision as of 01:02, 31 December 2005
Line 20:		Line 20:

	/Pontus		/Pontus

			== quotes fix for COMMAND ==

			Hi,

			previous post: obvisously the File Class description is missing in the sample after the file class ID.

			In the command if you use double quotes like in myExe.exe "%1", the script will think you have 5 parameters to WriteRegExp ( Nsis 2.12 ).
			Since it's unlikely anyone will use single quotes in a command, I suggest to fix it by remplacing the double quotes around {COMMAND} in the macro by single quotes:

			WriteRegStr HKCR "${FILECLASS}\shell\open\command" "" '${COMMAND}'

			Cedric.

85.235.1.20 at 11:20, 21 September 2005

2005-09-21T11:20:09Z

â† Older revision		Revision as of 11:20, 21 September 2005
Line 5:		Line 5:
	<nowiki>		<nowiki>
	; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \		; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \
			</nowiki>

			<nowiki>
	; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""		; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""
	</nowiki>		</nowiki>

	but in the fuction header there is six patrameters declared:		but in the fuction header there is six patrameters declared:

85.235.1.20 at 11:18, 21 September 2005

2005-09-21T11:18:25Z

â† Older revision		Revision as of 11:18, 21 September 2005
Line 2:		Line 2:

	In the example you call with five parameters:		In the example you call with five parameters:

	<nowiki>		<nowiki>
	; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \		; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \

	; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""		; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""
	</nowiki>		</nowiki>

85.235.1.20 at 11:18, 21 September 2005

2005-09-21T11:18:06Z

â† Older revision		Revision as of 11:18, 21 September 2005
Line 2:		Line 2:

	In the example you call with five parameters:		In the example you call with five parameters:
			<nowiki>
	; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \		; !insertmacro APP_ASSOCIATE "txt" "myapp.textfile" "$INSTDIR\myapp.exe,0" \
	; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""		; "Open with myapp" "$INSTDIR\myapp.exe $\"%1$\""
			</nowiki>
	but in the fuction header there is six patrameters declared:		but in the fuction header there is six patrameters declared: