Talk:Path Manipulation - Revision history

60.241.42.13: /* String size limitation */

2012-07-26T01:44:12Z

String size limitation

â† Older revision		Revision as of 01:44, 26 July 2012
Line 158:		Line 158:

	--[[User:Shmektse\|Shmektse]] 13:25, 20 June 2010 (UTC)		--[[User:Shmektse\|Shmektse]] 13:25, 20 June 2010 (UTC)

			I recommend changing

			StrCmp $1 "" AddToPath_NTdoIt

			to

			StrCmp $1 "" AddToPath_NTdone

			The path should never be empty, if it is it's going to be the bug, it's much better to not add something to the path than to clear the existing content.

Shmektse: /* String size limitation */

2010-06-20T13:25:14Z

String size limitation

â† Older revision		Revision as of 13:25, 20 June 2010
Line 156:		Line 156:
	If the PATH is bigger, this function will '''replace''' the whole PATH instead of just appending to it.		If the PATH is bigger, this function will '''replace''' the whole PATH instead of just appending to it.
	Temporarily you can use the large strings build of NSIS to avoid this problem.		Temporarily you can use the large strings build of NSIS to avoid this problem.

			--[[User:Shmektse\|Shmektse]] 13:25, 20 June 2010 (UTC)

Shmektse: /* String size limitation */ new section

2010-06-20T13:24:20Z

String size limitation: new section

â† Older revision		Revision as of 13:24, 20 June 2010
Line 150:		Line 150:
	Workaround is to add paths one by one but that leeds to additional code		Workaround is to add paths one by one but that leeds to additional code
	in my case.		in my case.

			== String size limitation ==

			Please note that NSIS default build has a string limit of 1024 characters.
			If the PATH is bigger, this function will '''replace''' the whole PATH instead of just appending to it.
			Temporarily you can use the large strings build of NSIS to avoid this problem.

Owillebo: /* Problem when handling path1;path2 */ new section

2010-01-07T10:39:26Z

Problem when handling path1;path2: new section

â† Older revision		Revision as of 10:39, 7 January 2010
Line 139:		Line 139:
	!macroend		!macroend
	!insertmacro RemoveFromPath ""		!insertmacro RemoveFromPath ""

			== Problem when handling path1;path2 ==

			When I add path1;path2 i.e. multiple paths f.i.;
			${EnvVarUpdate} $0 "PYTHONPATH" "P" "HKLM" "path1;path2"

			EnvVarUpdate always thinks the path to be added is not there yet so
			it keeps adding the paths resulting in a growing path.

			Workaround is to add paths one by one but that leeds to additional code
			in my case.

210.51.195.18 at 07:44, 15 December 2007

2007-12-15T07:44:16Z

â† Older revision		Revision as of 07:44, 15 December 2007
Line 84:		Line 84:
	I modifed the AddToPath and RemoveFromPath:		I modifed the AddToPath and RemoveFromPath:


	~~----~~
	; AddToPath - Adds the given dir to the search path.		; AddToPath - Adds the given dir to the search path.
	; Input - head of the stack		; Input - head of the stack
	~~; Note - Win9x systems requires reboot~~
	Function AddToPath		Function AddToPath
	Exch $0		Exch $0
Line 94:		Line 91:
	Push $2		Push $2

	#~~åŽ»æŽ‰è·¯å¾„åŽé¢çš„ åˆ†å·~~";" ~~æ–œæ~~ "/" ~~ä»¥åŠ åæ–œæ~~ "\"		#delete ";" "/" and "\"
	#~~åŽ»é™¤åˆ†å·~~		#;
	StrCpy $1 $0 1 -1		StrCpy $1 $0 1 -1
	StrCmp $1 ";" 0 +2		StrCmp $1 ";" 0 +2
	StrCpy $0 $0 -1		StrCpy $0 $0 -1
	#~~åŽ»é™¤æ–œæ ã€åæ–œæ~~		#"/" and "\"
	StrCpy $1 $0 1 -1		StrCpy $1 $0 1 -1
	StrCmp $1 "\" +2 +3		StrCmp $1 "\" +2 +3
Line 105:		Line 102:
	StrCpy $0 $0 -1		StrCpy $0 $0 -1

	#~~åˆ¤æ–è·¯å¾„æœ‰æ•ˆæ€§~~		#path
	IfFileExists "$0\." "" AddToPath_done		IfFileExists "$0\." "" AddToPath_done

210.51.195.18: Why not use the WordAdd Function?

2007-12-15T07:42:41Z

Why not use the WordAdd Function?

â† Older revision		Revision as of 07:42, 15 December 2007
Line 76:		Line 76:
	StrCmp $2 "" "" AddToPath_done</highlight-nsis>		StrCmp $2 "" "" AddToPath_done</highlight-nsis>
	::::That's a very specific case. It happens because running processes don't update their environment. You should manually update as shown in [[Setting Environment Variables to Active Installer Process]]. Your alternative solution may miss variables defined elsewhere. --[[User:Kichik\|kichik]] 01:18, 24 December 2006 (PST)		::::That's a very specific case. It happens because running processes don't update their environment. You should manually update as shown in [[Setting Environment Variables to Active Installer Process]]. Your alternative solution may miss variables defined elsewhere. --[[User:Kichik\|kichik]] 01:18, 24 December 2006 (PST)

			== Why not use the WordAdd Function? ==

			Hi:
			It seemed the WordAdd can do it.

			I modifed the AddToPath and RemoveFromPath:


			----
			; AddToPath - Adds the given dir to the search path.
			; Input - head of the stack
			; Note - Win9x systems requires reboot
			Function AddToPath
			Exch $0
			Push $1
			Push $2

			#åŽ»æŽ‰è·¯å¾„åŽé¢çš„ åˆ†å·";" æ–œæ "/" ä»¥åŠ åæ–œæ "\"
			#åŽ»é™¤åˆ†å·
			StrCpy $1 $0 1 -1
			StrCmp $1 ";" 0 +2
			StrCpy $0 $0 -1
			#åŽ»é™¤æ–œæ ã€åæ–œæ
			StrCpy $1 $0 1 -1
			StrCmp $1 "\" +2 +3
			StrCmp $1 "/" 0 +2
			StrCpy $0 $0 -1

			#åˆ¤æ–è·¯å¾„æœ‰æ•ˆæ€§
			IfFileExists "$0\." "" AddToPath_done

			DetailPrint "Adding $1 to $0"
			ReadRegStr $1 ${WriteEnvStr_RegKey} "PATH"
			${WordAdd} $1 ";" "+$0" $2

			WriteRegExpandStr ${WriteEnvStr_RegKey} "PATH" $2
			SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=5000

			AddToPath_done:
			Pop $2
			Pop $1
			Pop $0
			FunctionEnd

			!macro RemoveFromPath UN
			; RemoveFromPath - Remove a given dir from the path
			; Input: head of the stack
			Function ${UN}RemoveFromPath
			Exch $0
			Push $1
			Push $2

			DetailPrint "Removing $0 from Path"
			ReadRegStr $1 ${WriteEnvStr_RegKey} "PATH"
			${WordAdd} $1 ";" "-$0" $2

			WriteRegExpandStr ${WriteEnvStr_RegKey} "PATH" $2
			SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=5000

			Pop $2
			Pop $1
			Pop $0
			FunctionEnd
			!macroend
			!insertmacro RemoveFromPath ""

Kichik at 09:18, 24 December 2006

2006-12-24T09:18:02Z

â† Older revision		Revision as of 09:18, 24 December 2006
Line 75:		Line 75:
	Pop $2		Pop $2
	StrCmp $2 "" "" AddToPath_done</highlight-nsis>		StrCmp $2 "" "" AddToPath_done</highlight-nsis>
	::::That's a very specific case. It happens because running processes don't update their environment. You should manually update as shown in [[Setting Environment Variables to Active Installer Process]]. Your alternative solution may miss variables defined elsewhere.		::::That's a very specific case. It happens because running processes don't update their environment. You should manually update as shown in [[Setting Environment Variables to Active Installer Process]]. Your alternative solution may miss variables defined elsewhere. --[[User:Kichik\|kichik]] 01:18, 24 December 2006 (PST)

Kichik at 09:17, 24 December 2006

2006-12-24T09:17:40Z

â† Older revision		Revision as of 09:17, 24 December 2006
Line 69:		Line 69:
	::Both functions already read from the registry key itself before writing the new value. They only check in the global value to make sure the value doesn't already exist. I don't see the problem with that.--[[User:Kichik\|kichik]] 04:12, 22 December 2006 (PST)		::Both functions already read from the registry key itself before writing the new value. They only check in the global value to make sure the value doesn't already exist. I don't see the problem with that.--[[User:Kichik\|kichik]] 04:12, 22 December 2006 (PST)
	:::i had a problem, when install goes right after uninstall, ReadEnvStr reads some cached values, and goes to AddToPath_done label. i changed it to ReadRegStr which seems to read actual values. [[User:Mojo\|Mojo]] 06:12, 23 December 2006 (PST)		:::i had a problem, when install goes right after uninstall, ReadEnvStr reads some cached values, and goes to AddToPath_done label. i changed it to ReadRegStr which seems to read actual values. [[User:Mojo\|Mojo]] 06:12, 23 December 2006 (PST)
	~~:::~~		<highlight-nsis>ReadEnvStr $1 PATH
	<~~pre~~>
	ReadEnvStr $1 PATH
	Push "$1;"		Push "$1;"
	Push "$0;"		Push "$0;"
	Call StrStr		Call StrStr
	Pop $2		Pop $2
	StrCmp $2 "" "" AddToPath_done		StrCmp $2 "" "" AddToPath_done</highlight-nsis>
	</~~pre~~>		::::That's a very specific case. It happens because running processes don't update their environment. You should manually update as shown in [[Setting Environment Variables to Active Installer Process]]. Your alternative solution may miss variables defined elsewhere.

Mojo at 14:16, 23 December 2006

2006-12-23T14:16:53Z

@@ Line 68: / Line 68: @@
 ::AddToEnvVar was added later by someone else.
 ::Both functions already read from the registry key itself before writing the new value. They only check in the global value to make sure the value doesn't already exist. I don't see the problem with that.--[[User:Kichik|kichik]] 04:12, 22 December 2006 (PST)
-:::i had a problem, when install goes right after uninstall, ReadEnvStr reads some cached values, so, i changed to ReadRegStr which seems to read actual values. [[User:Mojo|Mojo]] 06:12, 23 December 2006 (PST)
+:::i had a problem, when install goes right after uninstall, ReadEnvStr reads some cached values, and goes to AddToPath_done label. i changed it to ReadRegStr which seems to read actual values. [[User:Mojo|Mojo]] 06:12, 23 December 2006 (PST)

Mojo at 14:12, 23 December 2006

2006-12-23T14:12:06Z

â† Older revision		Revision as of 14:12, 23 December 2006
Line 68:		Line 68:
	::AddToEnvVar was added later by someone else.		::AddToEnvVar was added later by someone else.
	::Both functions already read from the registry key itself before writing the new value. They only check in the global value to make sure the value doesn't already exist. I don't see the problem with that.--[[User:Kichik\|kichik]] 04:12, 22 December 2006 (PST)		::Both functions already read from the registry key itself before writing the new value. They only check in the global value to make sure the value doesn't already exist. I don't see the problem with that.--[[User:Kichik\|kichik]] 04:12, 22 December 2006 (PST)
			:::i had a problem, when install goes right after uninstall, ReadEnvStr reads some cached values, so, i changed to ReadRegStr which seems to read actual values. [[User:Mojo\|Mojo]] 06:12, 23 December 2006 (PST)