Fkaatje at 12:26, 11 August 2011

2011-08-11T12:26:16Z

â† Older revision		Revision as of 12:26, 11 August 2011
Line 43:		Line 43:
	FunctionEnd		FunctionEnd
	</highlight-nsis>		</highlight-nsis>

			[[User:Fkaatje\|Fkaatje]] 12:26, 11 August 2011 (UTC)

Fkaatje: Created page with "This script will not work for empty parent directories directly under root (NSIS 2.46). Say your app is under C:\test\myapp. In your uninstall section you call: RMDir "$INSTDIR"..."

2011-08-11T12:03:25Z

Created page with "This script will not work for empty parent directories directly under root (NSIS 2.46). Say your app is under C:\test\myapp. In your uninstall section you call: RMDir "$INSTDIR"..."

New page

This script will not work for empty parent directories directly under root (NSIS 2.46). Say your app is under C:\test\myapp. In your uninstall section you call:

RMDir "$INSTDIR"<br/>
${RMDirUP} "$INSTDIR"<br/>

This does remove myapps and test (provided they are empty), but then gets into a loop when trying to remove C:\test\myapp\..\..

RMDir on the root does not give an error and the script recursively continues with

RMDir C:\test\myapp\..\..\..<br\>
RMDir C:\test\myapp\..\..\..\..<br\>
RMDir C:\test\myapp\..\..\..\..\..<br\>
etc.

After some time the uninstaller exits and everything in your uninstall section after the RMDirUP call is not executed.

I'm not sure if this is a flaw in the script or a bug in the RMDir instruction.
My proposal would be to change the function as follows:

<highlight-nsis>
!include "FileFunc.nsh"

;--
;--

Function un.RMDirUP
!define RMDirUP '!insertmacro RMDirUPCall'
!macro RMDirUPCall _PATH
push '${_PATH}'
Call un.RMDirUP
!macroend
; $0 - current folder
ClearErrors
Exch $0
${GetParent} "$0" $R0
${GetRoot} "$0" $R1
StrCmp $R0 $R1 Skip 0
RMDir "$R0"
IfErrors Skip
${RMDirUP} "$R0"
Skip:
Pop $0
FunctionEnd
</highlight-nsis>

Talk:Recursively remove empty parent directories - Revision history

Fkaatje at 12:26, 11 August 2011

Fkaatje: Created page with "This script will not work for empty parent directories directly under root (NSIS 2.46). Say your app is under C:\test\myapp. In your uninstall section you call: RMDir "$INSTDIR"..."