Validating $INSTDIR before uninstall - Revision history

CJS: /* The Code */

2017-04-05T15:27:44Z

The Code

â† Older revision		Revision as of 15:27, 5 April 2017
Line 25:		Line 25:
	StrCpy $R0 $INSTDIR "" -8		StrCpy $R0 $INSTDIR "" -8
	StrCmp $R0 "\Desktop" bad		StrCmp $R0 "\Desktop" bad
	StrCpy $R0 $INSTDIR "" -22		StrCpy $R0 $INSTDIR "" -23
	StrCmp $R0 "\Documents and Settings" bad		StrCmp $R0 "\Documents and Settings" bad
	StrCpy $R0 $INSTDIR "" -13		StrCpy $R0 $INSTDIR "" -13

2007-07-23T12:05:13Z

Idiot Proofing Installers

â† Older revision		Revision as of 12:05, 23 July 2007
Line 68:		Line 68:

	== Idiot Proofing Installers ==		== Idiot Proofing Installers ==
	'''Don't use RMDir /r $INSTDIR'''		* '''Don't use RMDir /r $INSTDIR'''
	Instead, delete each file previously installed individually and then remove each folder with RMDir without the recursive (/r) switch. If you are really lazy you can write an installer to loop through your files list to generate your Delete and RMDir instructions: [[Invoking NSIS run-time commands on compile-time]].		Instead, delete each file previously installed individually and then remove each folder with RMDir without the recursive (/r) switch. If you are really lazy you can write an installer to loop through your files list to generate your Delete and RMDir instructions: [[Invoking NSIS run-time commands on compile-time]].

2007-07-23T12:04:42Z

Reflection

â† Older revision		Revision as of 12:04, 23 July 2007
Line 66:		Line 66:

	You can also use !insertmacro BadPathsCheck in your installer directory page's leave function to check that the user is not installing to a bad folder.		You can also use !insertmacro BadPathsCheck in your installer directory page's leave function to check that the user is not installing to a bad folder.

			== Idiot Proofing Installers ==
			'''Don't use RMDir /r $INSTDIR'''
			Instead, delete each file previously installed individually and then remove each folder with RMDir without the recursive (/r) switch. If you are really lazy you can write an installer to loop through your files list to generate your Delete and RMDir instructions: [[Invoking NSIS run-time commands on compile-time]].

	[[Category:Code_Examples]]		[[Category:Code_Examples]]

	Stu		Stu

2007-07-10T23:01:10Z

The Code

â† Older revision		Revision as of 23:01, 10 July 2007
Line 45:		Line 45:

	# Does path end with "\MyApp"?		# Does path end with "\MyApp"?
	~~StrCpy $R1~~ "\MyApp"		!define CHECK_PATH "\MyApp"
	StrLen $R2 $R1		StrLen $R1 "${CHECK_PATH}"
	StrCpy $R0 $INSTDIR "" -6		StrCpy $R0 $INSTDIR "" -$R1
	StrCmp $R0 $R1 +3		StrCmp $R0 "${CHECK_PATH}" +3
	MessageBox MB_YESNO\|MB_ICONQUESTION "Unrecognised uninstall path. Continue anyway?" IDYES +2		MessageBox MB_YESNO\|MB_ICONQUESTION "Unrecognised uninstall path. Continue anyway?" IDYES +2
	Abort		Abort

2007-07-10T22:58:19Z

The Code

â† Older revision		Revision as of 22:58, 10 July 2007
Line 44:		Line 44:
	!insertmacro BadPathsCheck		!insertmacro BadPathsCheck

	# Does path end with "\MyApp"? ~~Change -6 accordingly.~~		# Does path end with "\MyApp"?
			StrCpy $R1 "\MyApp"
			StrLen $R2 $R1
	StrCpy $R0 $INSTDIR "" -6		StrCpy $R0 $INSTDIR "" -6
	StrCmp $R0 ~~"\MyApp"~~ +3		StrCmp $R0 $R1 +3
	MessageBox MB_YESNO\|MB_ICONQUESTION "Unrecognised uninstall path. Continue anyway?" IDYES +2		MessageBox MB_YESNO\|MB_ICONQUESTION "Unrecognised uninstall path. Continue anyway?" IDYES +2
	Abort		Abort

2007-07-10T22:42:34Z

2007-07-10T22:41:43Z

@@ Line 12: / Line 12: @@
 == The Code ==
 <highlight-nsis>
 ClearErrors
 ReadRegStr $INSTDIR HKLM "Software\MyApp" ""
@@ Line 40: / Line 64: @@
 Another check at the end is for MyApp.exe. If that file does not exist then the uninstall path could possibly be bad.
 [[Category:Code_Examples]]
 Stu

2007-07-10T22:38:45Z

Bad paths detection

@@ Line 40: / Line 40: @@
 Another check at the end is for MyApp.exe. If that file does not exist then the uninstall path could possibly be bad.
 [[Category:Code_Examples]]
 Stu

2007-07-10T22:36:51Z

@@ Line 17: / Line 17: @@
 StrCmp $INSTDIR "" 0 +2
    StrCpy $INSTDIR $EXEDIR
 # Does path end with "\MyApp"? Change -6 accordingly.
 StrCpy $R0 $INSTDIR "" -6
 StrCmp $R0 "\MyApp" +3
-   MessageBox MB_YESNO|MB_ICONQUESTION "..." IDYES +2
+   MessageBox MB_YESNO|MB_ICONQUESTION "Unrecognised uninstall path. Continue anyway?" IDYES +2
    Abort
@@ Line 28: / Line 31: @@
    MessageBox MB_OK|MB_ICONSTOP "Install path invalid!"
    Abort
 </highlight-nsis>
@@ Line 38: / Line 39: @@
 Another check at the end is for MyApp.exe. If that file does not exist then the uninstall path could possibly be bad.
 [[Category:Code_Examples]]
 Stu

2007-07-10T22:18:02Z

The Code

â† Older revision		Revision as of 22:18, 10 July 2007
Line 15:		Line 15:
	ReadRegStr $INSTDIR HKLM "Software\MyApp" ""		ReadRegStr $INSTDIR HKLM "Software\MyApp" ""
	IfErrors +2		IfErrors +2
	StrCmp $INSTDIR "" 0 +3		StrCmp $INSTDIR "" 0 +2
	~~MessageBox MB_OK\|MB_ICONSTOP "Install path missing!"~~		StrCpy $INSTDIR $EXEDIR
	~~Abort~~

	# Does path end with "\MyApp"? Change -6 accordingly.		# Does path end with "\MyApp"? Change -6 accordingly.