Talk:Validating $INSTDIR before uninstall: Difference between revisions

From NSIS Wiki
Jump to navigationJump to search
(Char count is incorrect for "\Documents and Settings")
 
mNo edit summary
 
Line 9: Line 9:
I found this out when testing an install to "\Documents and Settings", of course it should have been rejected, but was not, creating a mess!
I found this out when testing an install to "\Documents and Settings", of course it should have been rejected, but was not, creating a mess!
[[User:CJS|CJS]] ([[User talk:CJS|talk]]) 19:21, 10 November 2016 (UTC)
[[User:CJS|CJS]] ([[User talk:CJS|talk]]) 19:21, 10 November 2016 (UTC)
In the absence of any challenge to my 10 November 2016 comment, I have now applied the correction to the main page.
[[User:CJS|CJS]] ([[User talk:CJS|talk]]) 15:29, 5 April 2017 (UTC)

Latest revision as of 15:30, 5 April 2017

I believe the line before 'StrCmp $R0 "\Documents and Settings" bad' is incorrect:

 StrCpy $R0 $INSTDIR "" -22

This should (with the correct character count) be:

 StrCpy $R0 $INSTDIR "" -23

I found this out when testing an install to "\Documents and Settings", of course it should have been rejected, but was not, creating a mess! CJS (talk) 19:21, 10 November 2016 (UTC)

In the absence of any challenge to my 10 November 2016 comment, I have now applied the correction to the main page. CJS (talk) 15:29, 5 April 2017 (UTC)