Talk:NSIS Service Lib: Difference between revisions
From NSIS Wiki
Jump to navigationJump to search
No edit summary |
(signaled a fix) |
||
Line 31: | Line 31: | ||
: You're correct. I've applied the fix, thanks. | : You're correct. I've applied the fix, thanks. | ||
: --[[User:Kichik|kichik]] 09:12, 5 January 2006 (PST) | : --[[User:Kichik|kichik]] 09:12, 5 January 2006 (PST) | ||
---- | |||
There is a tiny bug that makes the original registers swapped after the function | |||
Old code: | |||
---------------------------------------------------------- | |||
<highlight-nsis> | |||
321 Pop $5 | |||
322 Pop $6 | |||
323 Pop $7 | |||
324 Exch $0 | |||
325 !macroend | |||
</highlight-nsis> | |||
New code: | |||
---------------------------------------------------------- | |||
<highlight-nsis> | |||
321 Pop $5 | |||
322 Pop $7 | |||
323 Pop $6 | |||
324 Exch $0 | |||
325 !macroend | |||
</highlight-nsis> | |||
--[[User:Charlesb|Charlesb]] 05:25, 22 February 2006 (PST) |
Revision as of 13:25, 22 February 2006
I noticed that I couldn't create an "interactive" service using your otherwise excellent lib...here's the fix!
Old code:
199 !insertmacro CALL_GETPARAM $R4 "interact" "0x10" "lbl_interact" 200 StrCpy $6 0x10 201 IntCmp $R4 0 +2 202 IntOp $R4 $6 | 0x100 203 StrCpy $R4 $6 204 lbl_interact:
New code:
199 !insertmacro CALL_GETPARAM $R4 "interact" "0x10" "lbl_interact" 200 StrCpy $6 0x10 201 IntCmp $R4 0 +2 202 IntOp $6 $6 | 0x100 203 StrCpy $R4 $6 204 lbl_interact:
The (very slight) change is on line 202.
Thanks again,
Nathan Probst
- You're correct. I've applied the fix, thanks.
- --kichik 09:12, 5 January 2006 (PST)
There is a tiny bug that makes the original registers swapped after the function Old code:
321 Pop $5 322 Pop $6 323 Pop $7 324 Exch $0 325 !macroend
New code:
321 Pop $5 322 Pop $7 323 Pop $6 324 Exch $0 325 !macroend
--Charlesb 05:25, 22 February 2006 (PST)